Fix/dependent methods #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we could die with a <notype> when an implicit argument was not found.
Now handles included test if toplevel implicit is given, but not yet without.
The term in a SearchSuccess has already been adapted to the expected type.
…icits Nothing will be committed here, so setExplore... is the right method to pick.
Necessary to make implicit resolution of type-level peano numbers work. The current commit makes takes the inimal steps to make this happen. We could also consider sharpening using followAlias every type we constrain a result, or every time we adapt a type.
|
Other depmeth tests in pos/pending still give errors. Needs more investigation. |
| val constraint = ctx.typerState.constraint | ||
| def inst(tp: Type): Type = tp match { | ||
| case TypeBounds(lo, hi) => | ||
| if ((lo eq hi) || (hi <:< lo)(ctx.fresh.setExploreTyperState)) inst(lo) else NoType |
There was a problem hiding this comment.
Could you add a comment explaining why NoType instead of tp makes sense here?
is even shorter (and I think clearer than either solution). I wrote the const to save a closure. |
|
Sadly, Function.const(x) still needs eta expansion and a new closure as it is a method with two param lists, rather than a method with one param list that returns a Function. |
|
@retronym Ah, that got probably done when we introduced specialization. So, no need to use Function.const. We can drop them at some point in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes related to implicit resolution which make some more tests go through. In particular, typelevel Peano numbers. Review by @adriaanm maybe?